feat(mito): Implement SST format for mito2 #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenyag
changed the title
evenyag
force-pushed
the
feat/mito2-sst-format
branch
from
8cb4479
to
c619a17
Compare
evenyag
force-pushed
the
feat/mito2-sst-format
branch
from
c619a17
to
a466935
Compare
evenyag
force-pushed
the
feat/mito2-sst-format
branch
from
a554ce9
to
8123d3a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2178 +/- ##
===========================================
- Coverage 84.68% 84.29% -0.39%
===========================================
Files 698 700 +2
Lines 112701 113147 +446
===========================================
- Hits 95437 95377 -60
- Misses 17264 17770 +506 |
v0y4g3r
reviewed
Aug 16, 2023
waynexia
reviewed
Aug 17, 2023
waynexia
approved these changes
Aug 17, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore: update comment * feat: stream writer takes arrow's types * feat: Define Batch struct * feat: arrow_schema_to_store * refactor: rename * feat: write parquet in new format with tsids * feat: reader support projection * feat: Impl read compat * refactor: rename SchemaCompat to CompatRecordBatch * feat: changing sst format * feat: make it compile * feat: remove tsid and some structs * feat: from_sst_record_batch wip * chore: push array * chore: wip * feat: decode batches from RecordBatch * feat: reader converts record batches * feat: remove compat mod * chore: remove some codes * feat: sort fields by column id * test: test to_sst_arrow_schema * feat: do not sort fields * test: more test helpers * feat: simplify projection * fix: projection indices is incorrect * refactor: define write/read format * test: test write format * test: test projection * test: test convert record batch * feat: remove unused errors * refactor: wrap get_field_batch_columns * chore: clippy * chore: fix clippy * feat: build arrow schema from region meta in ReadFormat * feat: initialize the parquet reader at `build()` * chore: fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements the SST format for mito2 engine.
The new SST format encodes the primary keys in a memory-comparable format and stores them as dictionary arrays. We distinguish different time series by comparing the keys of the dictionary array while decoding the
RecordBatch.We store three internal columns in parquet:
__primary_key, the primary key of the row (tags).__sequence, the sequence number of a row.__op_type, the op type of the row.The schema of a parquet file is:
Checklist
Refer to a related PR or issue link (optional)