Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initialize mito2 crate #1875

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Jul 4, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR is a part of #1869. It initializes a new crate mito2 to experiment with refactoring the old mito engine to a region engine.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@evenyag evenyag marked this pull request as ready for review July 4, 2023 09:36
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1875 (5b4fc8a) into develop (2ef84f6) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1875      +/-   ##
===========================================
- Coverage    86.50%   86.17%   -0.34%     
===========================================
  Files          593      597       +4     
  Lines        96040    97142    +1102     
===========================================
+ Hits         83083    83711     +628     
- Misses       12957    13431     +474     

@waynexia waynexia merged commit 884731a into GreptimeTeam:develop Jul 4, 2023
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag deleted the chore/init-mito2 branch July 4, 2023 09:55
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants