Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus support #313

Closed
yuanbohan opened this issue Oct 17, 2022 · 6 comments
Closed

Prometheus support #313

yuanbohan opened this issue Oct 17, 2022 · 6 comments
Assignees
@killme2008

Comments

@yuanbohan
Copy link
Contributor

yuanbohan commented Oct 17, 2022 •
edited
Loading

features required

  • read data from db using PromQL
  • remote write
  • remote read
@killme2008
Copy link
Contributor

And push gateway protocol

@killme2008 killme2008 self-assigned this Oct 18, 2022
@killme2008
Copy link
Contributor

killme2008 commented Oct 18, 2022 •
edited
Loading

TODO:

  • remote write
  • remote read
  • push gateway

@yuanbohan
Copy link
Contributor Author

yuanbohan commented Oct 21, 2022 •
edited
Loading

Remote Read potential performance issues

@killme2008
Copy link
Contributor

Yep, we will implement the stream protocol.I am working on remote read right now.

@killme2008 killme2008 mentioned this issue Oct 25, 2022
Merged
@killme2008
Copy link
Contributor

killme2008 commented Nov 1, 2022 •
edited
Loading

Stream protocol is based on promethues's codec format, and it's an optimization between prometheus instances. So we don't need to impl it.

And the pushgateway in fact is a metric cache , not a push protocol at all.

We have to impl the PromQL in greptimedb in future.

@killme2008
Copy link
Contributor

Supports PromQL is tracked by #596

So I close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@killme2008 killme2008

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@killme2008 @yuanbohan