Fix Document > Clear Artboards so it doesn't also clear everything else

[moOsama76]

Continuation of first attempt with unmerged PR #2015

[Keavon]

!build

[github-actions]

📦 Build Complete for fb422f7
https://28720137.graphite.pages.dev

[Keavon]

Problem: this introduces an intermediate history step which you'll see if you open the graph and undo three times to get back when it should have taken just one step.

Other minor problem: it seems that the Artboard layer gets replaced by a Merge layer but it ends up in a different position in the graph. Ideally this wouldn't cause the layers to shift. In a case with multiple artboards each containing layers, I'm finding this even results in things overlapping in the graph after running this which isn't a suitable outcome.

Thanks, and welcome back!

[Keavon]

!build

[github-actions]

📦 Build Complete for f6587ca
https://a35a885b.graphite.pages.dev

[Keavon]

Can you please make it add a Transform node, feeding into the replacement Merge node, if the artboard has a nonzero Location? Currently, all former artboards teleport to having a top-left location at the canvas origin since the artboard offset is lost.

[Keavon]

Marking this as a draft in the meantime. And copying what I sent you in Discord for convenient reference:

Hi, I got a chance to review your PR again (sorry I've been so so so busy lately). It looks like the way you apply transformation of the artboard to the constituent layers is by deeply traversing the layer hierarchy and applying it to the roots. But this seems to cause bugs (for example, try setting the artboard for Isometric Fountain to a non-default X, Y position then clearing artboards and watch how the plants and pond ripples move). It's also not necessarily desirable how it ends up adding Transform nodes to all the individual layers rather than setting it on just one upstream Transform node that already exists. Can you make it set the Transform node on the least-nested layer of each artboard-that-becomes-a-layer rather than deeply setting it on all deepest-nested layers?

Thanks and great work so far, this is close!

[moOsama76]

Marking this as a draft in the meantime. And copying what I sent you in Discord for convenient reference:

Hi, I got a chance to review your PR again (sorry I've been so so so busy lately). It looks like the way you apply transformation of the artboard to the constituent layers is by deeply traversing the layer hierarchy and applying it to the roots. But this seems to cause bugs (for example, try setting the artboard for Isometric Fountain to a non-default X, Y position then clearing artboards and watch how the plants and pond ripples move). It's also not necessarily desirable how it ends up adding Transform nodes to all the individual layers rather than setting it on just one upstream Transform node that already exists. Can you make it set the Transform node on the least-nested layer of each artboard-that-becomes-a-layer rather than deeply setting it on all deepest-nested layers?

Thanks and great work so far, this is close!

It's okay I am not like waiting for it to be merged, I appreciate you reviews :)