Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/custom flow label #123

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/custom flow label #123

wants to merge 2 commits into from

Conversation

CKodes
Copy link
Collaborator

@CKodes CKodes commented Dec 14, 2024

This PR adds...

  • Fix regex assignment for scanDataEncoded
  • Remove invalid base64 characters in base64Decode
  • I've kept this PR as small as possible (~500 lines) by splitting it into PRs with manageable chunks of code
  • I've requested reviews from 1 reviewer
  • I've tested existing features (website scan, sitemap, custom flow)
  • I've synced this fork with GovTechSG repo
  • I've added/updated unit tests (N.A.)
  • I've added/updated any necessary dependencies in package[-lock].json npm audit, portable installation on GitHub Actions

@CKodes CKodes requested a review from younglim December 14, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younglim younglim Awaiting requested review from younglim

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CKodes