Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_datasets.ipynb to use Standard SQL and google-cloud-bigquery #312

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

alixhami
Copy link
Collaborator

This PR makes progress toward #290

There are two updates in this PR:

  • Change library for interacting with BigQuery to google-cloud-bigquery
  • Change SQL syntax to Standard SQL (as opposed to Legacy SQL)

The hashing function changed in Standard SQL, which affected the results in this notebook. Take a look to see if any additional changes need to be made to the content given the change in results.

@alixhami alixhami requested a review from alexhanna October 22, 2018 17:54
@lakshmanok
Copy link
Contributor

When I tried it out recently, Datalab did not ship with a working version of google-cloud-bigquery (the make_exception package was missing) and so I had to pip install the package ...

See: https://github.com/GoogleCloudPlatform/training-data-analyst/blob/master/blogs/bqml/taxifare_bqml.ipynb

@alixhami
Copy link
Collaborator Author

@lakshmanok I'll follow up with them on the version of google-cloud-bigquery, but I'll add an installation to this PR as well.

Side note - in the notebook you linked, why is the google-cloud-bigquery library being installed but then called through pandas-gbq? I think it will be confusing for users if there is content with the client library (google-cloud-bigquery), Datalab's BQ module, and pandas-gbq all in the same repo.

Copy link
Contributor

@alexhanna alexhanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and will most likely work for the the rest of the labs going forward.

@alexhanna alexhanna merged commit ccb2f39 into GoogleCloudPlatform:master Oct 22, 2018
@alixhami alixhami deleted the bq-library-update branch October 23, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants