Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump datadog-api-client to v2.31.0 #1937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

inikotoran
Copy link

@inikotoran inikotoran commented Oct 16, 2024

Bumping datadog-api-client to latest available version (v2.31.0)

In particular, with the latest version I'd like to enable import for datadog_service_level_objective resource with type = time_slice

I've tested this locally to import time_slice SLO

➜  go run main.go import datadog --resources=service_level_objective --filter="service_level_objective=id:$SLO_ID" --api-key "$DD_API_KEY" --app-key "$DD_APP_KEY"

Result:

resource "datadog_service_level_objective" "tfer--service_level_objective_id" {
  name = "test time_slice"

  sli_specification {
    time_slice {
      comparator = ">"

      query {
        formula {
          formula_expression = "default_zero(query1)"
        }

        query {
          metric_query {
            data_source = "metrics"
            name        = "query1"
            query       = "sum:http.client.hits{}.as_count()"
          }
        }
      }

      query_interval_seconds = "300"
      threshold              = "0"
    }
  }

  tags             = []
  target_threshold = "99.9"

  thresholds {
    target    = "99.9"
    timeframe = "7d"
    warning   = "0"
  }

  timeframe = "7d"
  type      = "time_slice"
}

@inikotoran inikotoran marked this pull request as ready for review October 16, 2024 09:40
@inikotoran
Copy link
Author

hi @sergeylanzman,
Can you help to review this PR? or redirect me to the information on how to get it reviewed?
I can't find anything in the CONTRIBUTING file
Thanks!
*sorry for tagging you (I saw your name in the AUTHOR file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant