feat: Laravel on Cloud Run #1680

glasnt · 2022-08-29T23:07:19Z

Code and README-based tutorial for Laravel on Cloud Run

Includes some region tags as highlighted in "Understanding the code".

(View to possibly migrate README tutorial to DevSite, but if that happens I'll submit another PR to redirect readers to that version)

snippet-bot · 2022-08-29T23:07:42Z

Here is the summary of changes.

You are about to add 2 region tags.

run/laravel/bootstrap/app.php:43, tag cloudrun_laravel_secret_manager_mount
run/laravel/routes/web.php:31, tag cloudrun_laravel_display_metadata

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

…avel

glasnt · 2022-08-29T23:56:13Z

Unsure why linting is failing.


Files that were not fixed due to errors reported during linting before fixing:
   1) /tmpfs/src/github/php-docs-samples/run/laravel/app/Providers/RouteServiceProvider.php

saranshdhingra · 2022-09-12T15:36:13Z

@glasnt I believe that is happening due to the use of ?-> operator in the RouteServiceProvider.php file. This was introduced in PHP 8, while the linter is running an image containing PHP 7.4 see this.

When I ran the fixer on your PR locally with PHP 7.3 in verbose mode I got the "Invalid file syntax" error.
On PHP 8.1 there were no changes.

Now, since this RouteServiceProvider.php is provided by the framework itself, we can either,

Ignore this and force merge.
Downgrade the Laravel version to be the one compatible to PHP 7.4.
Add an exclusion in the config file for php-cs-fixer.

@bshaffer Does this look right?

run/laravel/app/Providers/RouteServiceProvider.php

Co-authored-by: Brent Shaffer <[email protected]>

glasnt · 2022-11-04T04:30:13Z

tests all pass now 🥳

run/laravel/composer.json

bshaffer

Great tutorial!! I was able to get from beginning to end without any issues! I have a few comments related to minor tutorial based things, and only one major issue, which has to do with PHP versions (both required locally and deployed to). Please let me know if you have any questions!

compute/api-client/helloworld/app.php

functions/http_content_type/index.php

run/laravel/tests/Unit/ExampleTest.php

run/laravel/app/Http/helpers.php

run/laravel/routes/web.php

run/laravel/README.md

This reverts commit 09c539a.

…avel

Co-authored-by: Brent Shaffer <[email protected]>

…avel

run/laravel/README.md

glasnt · 2022-12-13T00:23:19Z

run/laravel/Procfile

@@ -0,0 +1,3 @@
+web: pid1 --nginxBinaryPath nginx --nginxConfigPath /layers/google.php.webconfig/webconfig/nginx.conf --serverConfigPath /layers/google.php.webconfig/webconfig/nginxserver.conf --nginxErrLogFilePath /var/log/nginx.log --customAppCmd "php-fpm -R --nodaemonize --fpm-config /layers/google.php.webconfig/webconfig/php-fpm.conf" --pid1LogFilePath /var/log/pid1.log --mimeTypesPath /layers/google.utils.nginx/nginx/conf/mime.types --customAppSocket /layers/google.php.webconfig/webconfig/app.sock


Just confirmed this setup vs the current buildpack web config, and it's still 'up to date', and the logs end up in Cloud Run successfully.

glasnt · 2022-12-13T00:23:43Z

One noop comment, I'm happy with this being merged when you are.

glasnt added 9 commits August 29, 2022 14:14

Laravel on Cloud Run -- initial code

d3ea481

Add procfile with re-routed log files to Cloud Run visible places

f7f1c3c

Create README.md

300df47

Fix formatting

e7fb062

Show demo outcome

d43b0eb

php-cs-fixer

17488fa

Resize/rescale demo screenshot

f4ba7e5

Update README.md

34d1c4f

Update README.md for launch

a3775db

glasnt requested a review from a team as a code owner August 29, 2022 23:07

product-auto-label bot added the samples Issues that are directly related to samples. label Aug 29, 2022

Merge branch 'master' into laravel

1c8be7b

glasnt added 3 commits August 30, 2022 09:15

php-cs-fixer w/.php-cs-fixer.dist.php config

3e18156

Merge branch 'laravel' of github.com:glasnt/php-docs-samples into lar…

11c8056

…avel

Apply php-cs-fix to all files in config, outside my demo

09c539a

bshaffer reviewed Sep 12, 2022

View reviewed changes

run/laravel/app/Providers/RouteServiceProvider.php Outdated Show resolved Hide resolved

glasnt and others added 4 commits September 13, 2022 07:54

Update run/laravel/app/Providers/RouteServiceProvider.php

0e36cb5

Co-authored-by: Brent Shaffer <[email protected]>

Merge branch 'master' into laravel

84b934b

Merge branch 'master' into laravel

07af9e2

Merge branch 'master' into laravel

8c8da02

Merge branch 'master' into laravel

9bd19f3

bshaffer reviewed Dec 1, 2022

View reviewed changes

run/laravel/composer.json Outdated Show resolved Hide resolved

run/laravel/composer.json Show resolved Hide resolved

glasnt and others added 2 commits December 2, 2022 08:41

Update dependencies

9c0f499

Merge branch 'main' into laravel

7b3c3ef

bshaffer reviewed Dec 9, 2022

View reviewed changes

Merge branch 'main' into laravel

4842971

glasnt and others added 15 commits December 12, 2022 08:28

Revert "Apply php-cs-fix to all files in config, outside my demo"

b788437

This reverts commit 09c539a.

Merge branch 'laravel' of github.com:glasnt/php-docs-samples into lar…

9e41a88

…avel

Move PROJECTNUM

aab5810

Update REGION, clarify update steps

065ed58

update minimum PHP (pending changes in comments)

8e39de8

Move tests to test/ (might fix kokoro?)

d8c9e4f

Reorder template envs

875159a

Make registry name an envvar

d6d02a4

Unpin expected version output

96eae35

Update run/laravel/routes/web.php

e24ab87

Co-authored-by: Brent Shaffer <[email protected]>

Update asset bucket/url notes

36549f4

Merge branch 'laravel' of github.com:glasnt/php-docs-samples into lar…

c8c47b6

…avel

remove unused app/helpers.php, update docs to suit

cbb857c

Update reasoning for local installations

ab14be7

Merge branch 'main' into laravel

ac9f702

bshaffer reviewed Dec 12, 2022

View reviewed changes

run/laravel/README.md Outdated Show resolved Hide resolved

bshaffer and others added 3 commits December 12, 2022 13:39

Update run/laravel/README.md

5c8e22b

Merge branch 'main' into laravel

62aca7d

Merge branch 'main' into laravel

87f466e

glasnt commented Dec 13, 2022

View reviewed changes

bshaffer approved these changes Dec 13, 2022

View reviewed changes

bshaffer merged commit f9a2245 into GoogleCloudPlatform:main Dec 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Laravel on Cloud Run #1680

feat: Laravel on Cloud Run #1680

glasnt commented Aug 29, 2022

snippet-bot bot commented Aug 29, 2022 •

edited

Loading

glasnt commented Aug 29, 2022

saranshdhingra commented Sep 12, 2022

glasnt commented Nov 4, 2022

bshaffer left a comment

glasnt Dec 13, 2022

glasnt commented Dec 13, 2022

		@@ -0,0 +1,3 @@
		web: pid1 --nginxBinaryPath nginx --nginxConfigPath /layers/google.php.webconfig/webconfig/nginx.conf --serverConfigPath /layers/google.php.webconfig/webconfig/nginxserver.conf --nginxErrLogFilePath /var/log/nginx.log --customAppCmd "php-fpm -R --nodaemonize --fpm-config /layers/google.php.webconfig/webconfig/php-fpm.conf" --pid1LogFilePath /var/log/pid1.log --mimeTypesPath /layers/google.utils.nginx/nginx/conf/mime.types --customAppSocket /layers/google.php.webconfig/webconfig/app.sock

feat: Laravel on Cloud Run #1680

feat: Laravel on Cloud Run #1680

Conversation

glasnt commented Aug 29, 2022

snippet-bot bot commented Aug 29, 2022 • edited Loading

glasnt commented Aug 29, 2022

saranshdhingra commented Sep 12, 2022

glasnt commented Nov 4, 2022

bshaffer left a comment

Choose a reason for hiding this comment

glasnt Dec 13, 2022

Choose a reason for hiding this comment

glasnt commented Dec 13, 2022

snippet-bot bot commented Aug 29, 2022 •

edited

Loading