Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update from main #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update from main #27

wants to merge 3 commits into from

Conversation

catwang42
Copy link

update from main

@google-cla
Copy link

google-cla bot commented Oct 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ngeorger
ngeorger suggested changes Dec 11, 2022
View reviewed changes
Copy link

@ngeorger ngeorger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I think you make a mistake when you tried to push your changes :) Maybe this commit should use your own remote, not the public one. Regards.

ngeorger
ngeorger suggested changes Dec 11, 2022
View reviewed changes
Copy link

@ngeorger ngeorger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes not belong to the public repo.

ngeorger
ngeorger suggested changes Dec 11, 2022
View reviewed changes
Copy link

@ngeorger ngeorger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistaken changes, should be used in private implementation.

ngeorger
ngeorger reviewed Dec 31, 2022
View reviewed changes
Copy link

@ngeorger ngeorger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pull request containing personal implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngeorger ngeorger ngeorger requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catwang42 @ngeorger