Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting namespace to the GA provider #12644

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

erikmej-code
Copy link

In an effort to promote the namespace to the GA provider we do the following:

  1. Remove instances of min_version from Namespace.yaml and include the uid field within properties.
  2. Include a test file, service_directory_namespace_ga.tf.tmpl, with the provider omitted.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


Add example file where provider is omitted.
Update `Namespace.yaml` to include the `uid` property and remove instances of `min_version`.
@github-actions github-actions bot requested a review from shuyama1 December 23, 2024 19:59
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants