-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): add change streams transaction exclusion sample #4108
feat(spanner): add change streams transaction exclusion sample #4108
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
88370b5
to
cfdb7cf
Compare
2f07027
to
8ffcfc1
Compare
CI is still reporting failures:
Is this expected? (or do we just need to update the client library version?) We should hold off merging this until CI passes, as we do not want to have broken samples included in our documentation. please let me know how you'd like to proceed. |
Hi! Sorry for the confusion, I just converted this cl into a draft. Yes this is expected since this feature is still under limited visibility. I'll re-open this pr once this feature is turned on by default in production. Thanks! |
It looks like this PR has been in draft form for several months. @ShuranZhang I'm going to close it, for now. Feel free to create a new PR from your local branch when the sample is ready. Thank you! |
Add sample for how to configure change streams transaction exclusion in various write APIs.
Note: the current latest release of spanner go client library does not contain the source code change in googleapis/google-cloud-go#9779 yet, so there will be build failures in CI/CD. However I have verified that all IT tests passed after pointing the go client dependency to my newest local cloned copy.
This pr will not be merged until the latest go client release contains the necessary source code change, just uploading it now to kick off the review process earlier.