-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(speech): Add speech StreamingRecognize samples #3753
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
1fd7b83
to
7adefda
Compare
These should be in the snippets/ folder, similar to the others: https://github.com/GoogleCloudPlatform/golang-samples/tree/main/speech/snippets And can you make them analogous to the python samples? https://github.com/GoogleCloudPlatform/python-docs-samples/tree/196be7a900be64ed5429a17f07e28ac255e20642/speech/snippets |
Thanks Shubham and Kodanda for implementing on the ask and creating the PR. I am working with product team to merge the same. |
@nitsanshai Thank you for the review. Working on it. |
Sure, let me look into these changes tomorrow.
…On Mon, Jan 22, 2024 at 10:22 PM hpkaur86 ***@***.***> wrote:
@nitsanshai <https://github.com/nitsanshai> Thank you for the review.
Working on it.
—
Reply to this email directly, view it on GitHub
<#3753 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWBERBQNJJLLTVRBFF5BRDYP2KOTAVCNFSM6AAAAABCFJ4MCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGQYTCMRXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Thanks & Regards,
Shubham
Cell: +91-7022-03-1114/ +91-9899-63-9828
Skype: annu.shubham
|
@nitsanshai , as per your suggestion code has been changed. Please review the same. |
Can you change the PR name to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since they are so similar, please address the comments on transcribe_streaming_v2
in the explicit decoding sample as well. Thanks!
@muncus , please review this |
Description
Added support to stt v2 apis for livecaption and livecaption_from_file. Missing for a customer to follow with samples.
Fixes #3754 Required the support the stt_v2 apis
Feat # Add support for stt v2 apis
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)