Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing timer based cleanup logic #2927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abhishek10004
Copy link
Collaborator

@abhishek10004 abhishek10004 commented Jan 22, 2025

Removing timer based cleanup logic (Created b/391508479 to track restoring it back)

Making this change against b/388177094

@abhishek10004 abhishek10004 added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.59%. Comparing base (d45540f) to head (e20697d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2927      +/-   ##
==========================================
- Coverage   75.62%   75.59%   -0.04%     
==========================================
  Files         125      125              
  Lines       17641    17618      -23     
==========================================
- Hits        13341    13318      -23     
- Misses       3738     3739       +1     
+ Partials      562      561       -1     
Flag Coverage Δ
unittests 75.59% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhishek10004 abhishek10004 marked this pull request as ready for review January 22, 2025 11:58
@abhishek10004 abhishek10004 requested a review from a team as a code owner January 22, 2025 11:58
@kislaykishore kislaykishore requested review from a team, tritone and gargnitingoogle and removed request for a team and tritone January 22, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant