Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update langchain-observability-snippet.ipynb #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpantsjoha
Copy link

fixing the auth snippet section

Copy link

google-cla bot commented Dec 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@RajeshThallam
Copy link
Collaborator

@jpantsjoha Thanks for the contribution. Can you please look at the failed checks? You may have to sign the CLA?

Copy link
Member

@michaelwsherman michaelwsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for this. But @jpantsjoha we still need a CLA and this should be refactored to point to the new location for this notebook (applied-ai-engineering-samples/genai-on-vertex-ai/langchain_observability_snippet/langchain-observability-snippet.ipynb .

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jpantsjoha
Copy link
Author

done. CLA signed.

@jpantsjoha jpantsjoha requested a review from michaelwsherman May 9, 2024 10:53
@michaelwsherman
Copy link
Member

Still errors -- click into the CLA error, make sure you've signed it with that email.

Also, there's a merge conflict, please resolve that so it can be merged into main.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants