Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reasoning engine + multimodal agent sample notebook #106

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,5 @@ venv.bak/
data/

# files
scratchpad.md
scratchpad.md
.idx/dev.nix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

It's good practice to include a comment explaining what this line ignores. For instance, if it's intended to ignore a nix cache directory, a comment like # Ignore nix cache directory would improve clarity and maintainability.

Suggested change
.idx/dev.nix
.idx/dev.nix # Ignore nix cache directory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Adding a comment explaining the purpose of ignoring .idx/dev.nix would improve the clarity of this entry. For example, is this related to a specific development environment or tool?

Suggested change
.idx/dev.nix
.idx/dev.nix # Ignore IDX development environment files

6 changes: 4 additions & 2 deletions docs/mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,10 @@ nav:
- Building Grounded RAG App: genai-on-vertex-ai/retrieval_augmented_generation/diy_rag_with_vertexai_apis/build_grounded_rag_app_with_vertex.ipynb
- Agents:
# - Overview: genai-on-vertex-ai/agents/
# - Reasoning Engine:
# - Overview: genai-on-vertex-ai/agents/reasoning_engine/langchain_on_reasoning_engine/README.md
- Reasoning Engine:
- Langchain on Reasoning Engine:
- Overview: genai-on-vertex-ai/agents/reasoning_engine/langchain_on_reasoning_engine/README.md
- Multimodal Support Concierge Agent: genai-on-vertex-ai/agents/reasoning_engine/langchain_on_reasoning_engine/multimodal_google_nest_support_agent_w_langchain_reasoning_engine.ipynb
- Overview: genai-on-vertex-ai/vertex_ai_extensions/README.md

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The "Overview" entry for Vertex AI Extensions is duplicated. While this might be intentional, it could be confusing. Consider removing the duplicate entry or adding a comment to clarify its purpose.

Suggested change
- Overview: genai-on-vertex-ai/vertex_ai_extensions/README.md
- Vertex AI Extensions:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The "Overview" link appears twice under Agents. One of these entries should be removed to avoid redundancy and maintain clarity in the navigation structure.

Suggested change
- Overview: genai-on-vertex-ai/vertex_ai_extensions/README.md
- Vertex AI Extensions:
- Overview: genai-on-vertex-ai/vertex_ai_extensions/README.md

- Vertex AI Extensions:
- Overview: genai-on-vertex-ai/vertex_ai_extensions/README.md
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Langchain on Vertex AI Reasoning Engine

In this set of notebooks, we will explore how to build an end to end agent with Langchain and deploy it on Vertex AI Reasoning Engine.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Minor suggestion: Change "end to end" to "end-to-end" for better readability.

Suggested change
In this set of notebooks, we will explore how to build an end to end agent with Langchain and deploy it on Vertex AI Reasoning Engine.
In this set of notebooks, we will explore how to build an end-to-end agent with Langchain and deploy it on Vertex AI Reasoning Engine.


1. [Multimodal Google Nest Support / Concierge Agent](genai-on-vertex-ai/agents/reasoning_engine/langchain_on_reasoning_engine/multimodal_google_nest_support_agent_w_langchain_reasoning_engine.ipynb) - This agent takes a video of the user describing their issues about Google Nest products, uses a combination of Gemini multimodality as well as Vertex AI Search to solve customer issues.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Using a relative path or the full URL to the notebook on GitHub would make the link more robust and platform-independent. Currently, the path assumes a specific directory structure, which might not be applicable in all contexts.

Suggested change
1. [Multimodal Google Nest Support / Concierge Agent](genai-on-vertex-ai/agents/reasoning_engine/langchain_on_reasoning_engine/multimodal_google_nest_support_agent_w_langchain_reasoning_engine.ipynb) - This agent takes a video of the user describing their issues about Google Nest products, uses a combination of Gemini multimodality as well as Vertex AI Search to solve customer issues.
1. [Multimodal Google Nest Support / Concierge Agent](./multimodal_google_nest_support_agent_w_langchain_reasoning_engine.ipynb) - This agent takes a video of the user describing their issues about Google Nest products, uses a combination of Gemini multimodality as well as Vertex AI Search to solve customer issues.

Loading