Skip to content

Commit

Permalink
fix more linter errors
Browse files Browse the repository at this point in the history
  • Loading branch information
Abhishekbhagwat committed Dec 19, 2024
1 parent 8cbf2ec commit 2490f92
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
22 changes: 11 additions & 11 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@

Thank you for your contribution! Please provide a brief description of your changes and ensure you've completed the checklist below.

### Description
## Description

What does this PR do? Why is it necessary?

**Fixes #<Issue Number>** (if applicable)

### Checklist
## Checklist

* [ ] **Contribution Guidelines:** I have read the [Contribution Guidelines](../CONTRIBUTING).
* [ ] **CLA:** I have signed the [CLA](https://cla.developers.google.com).
* [ ] **Authorship:** I am listed as the author (if applicable).
* [ ] **Conventional Commits:** My PR title and commit messages follow the [Conventional Commits](https://www.conventialcommits.org) spec.
* [ ] **Code Format:** I have run `nox -s format` to format the code.
* [ ] **Spelling:** I have fixed any spelling errors, and added false positives to .github/actions/spelling/allow.txt if necessary.
* [ ] **Template:** I have followed the `aaie_notebook_template.ipynb` if submitting a new jupyter notbook.
* [ ] **Sync:** My Fork is synced with the upstream.
* [ ] **Documentations:** I have updated relevant documentations (if applicable) in the [docs folder](../docs).
- [ ] **Contribution Guidelines:** I have read the [Contribution Guidelines](../CONTRIBUTING).
- [ ] **CLA:** I have signed the [CLA](https://cla.developers.google.com).

Check warning on line 14 in .github/PULL_REQUEST_TEMPLATE.md

View workflow job for this annotation

GitHub Actions / Check Spelling

`CLA` is not a recognized word. (unrecognized-spelling)

Check notice on line 14 in .github/PULL_REQUEST_TEMPLATE.md

View workflow job for this annotation

GitHub Actions / Check Spelling

`Line` matches candidate pattern `(?:\b(?:https?|ftp|file)://)[-A-Za-z0-9+&@#/%?=~_|!:,.;]+[-A-Za-z0-9+&@#/%=~_|]` (candidate-pattern)

Check warning on line 14 in .github/PULL_REQUEST_TEMPLATE.md

View workflow job for this annotation

GitHub Actions / Check Spelling

`cla` is not a recognized word. (unrecognized-spelling)
- [ ] **Authorship:** I am listed as the author (if applicable).
- [ ] **Conventional Commits:** My PR title and commit messages follow the [Conventional Commits](https://www.conventialcommits.org) spec.
- [ ] **Code Format:** I have run `nox -s format` to format the code.
- [ ] **Spelling:** I have fixed any spelling errors, and added false positives to .github/actions/spelling/allow.txt if necessary.
- [ ] **Template:** I have followed the `aaie_notebook_template.ipynb` if submitting a new jupyter notbook.
- [ ] **Sync:** My Fork is synced with the upstream.
- [ ] **Documentations:** I have updated relevant documentations (if applicable) in the [docs folder](../docs).
4 changes: 2 additions & 2 deletions .github/workflows/linter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,5 @@ jobs:
VALIDATE_GITHUB_ACTIONS: false
VALIDATE_YAML_PRETTIER: false
VALIDATE_JSCPD: false
- name: Make script executable
run: chmod +x .github/workflows/notebook_linter/run_linter.sh
FIX_SHELL_SHFMT: true
VALIDATE_BASH_EXEC: false

0 comments on commit 2490f92

Please sign in to comment.