chore: update commons-compress to 1.26.1 #1020
Conversation
| @@ -112,12 +112,6 @@ | |||
| <scope>provided</scope> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>commons-io</groupId> | |||
| <artifactId>commons-io</artifactId> | |||
There was a problem hiding this comment.
commons-io is a dependency of commons-compress so that we don't need to define this dependency anymore.
The current version, 2.7, is incompatible with commons-compress 1.26.1.
There was a problem hiding this comment.
This module uses FileUtils from commons-io. Please keep this declaration.
However, it's only used in FileUtils.deleteDirectory(stagingDirectory.toFile()). Can you see whether it can be replaced by Guava's method? https://guava.dev/releases/32.0.0-jre/api/docs/com/google/common/io/MoreFiles.html#deleteRecursively(java.nio.file.Path,com.google.common.io.RecursiveDeleteOption...) If it works, then this module does not need to declare the dependency.
There was a problem hiding this comment.
I tested guava's deleteRecursively but the following error occurred:
Caused by: com.google.common.io.InsecureRecursiveDeleteException: /var/folders/2b/zvjk1hd11jx5kmjj2s8my6tr00zvqy/T/junit17596486141951131749: unable to guarantee security of recursive delete
at com.google.common.io.MoreFiles.checkAllowsInsecure(MoreFiles.java:750)
at com.google.common.io.MoreFiles.deleteRecursively(MoreFiles.java:542)
at com.google.cloud.tools.maven.stage.AppEngineWebXmlStager.stage(AppEngineWebXmlStager.java:61)
The test passed by using RecursiveDeleteOption.ALLOW_INSECURE, but I'm not sure whether this is a good option.
I'll update the dependency version instead.
|
Thank you |
No description provided.