Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Performance improvements #382

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

🔥 Performance improvements #382

wants to merge 13 commits into from

Conversation

argyleink
Copy link
Member

over time the selection and gui creation mechanisms's responsibilities were spread out. they've been unified where appropriate, resulting in multi-select, search queries, or anything that creates alot of gui, being 50% or 100% faster. Extreme cases are 80 nodes drawing their gui at 30ms or so, vs 80 nodes at 100ms

try it:
https://visbug-perf.glitch.me

changes:

  • bulk and async getBoundingClientRect
  • single document.body incision for appending visbug gui

fixes #112
fixes #225
fixes #160


before

Screen Shot 2019-09-04 at 10 50 29 PM

after

Screen Shot 2019-09-04 at 10 49 49 PM

@argyleink argyleink added the 🔥 enhancement New feature or request label Sep 5, 2019
@argyleink argyleink changed the base branch from master to main June 12, 2020 16:23
@argyleink argyleink marked this pull request as draft January 14, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 enhancement New feature or request
Projects
None yet
1 participant