Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated console logging #119

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Updated console logging #119

merged 1 commit into from
Apr 26, 2023

Conversation

rviscomi
Copy link
Member

This is a followup to #115, which introduced logging diagnostic info. These changes include:

  • Using console groups for each metric log
    • Moving all instances of the extension prefix ([Web Vitals Extension]) to the top-level groups, ie out of table headers
    • Color-coding the metric value by threshold rating
  • Individual logs within each group for high-level diagnostic info
    • the LCP element
    • a warning that the LCP was inflated when the tab was loaded in the background (parity with the popup)
    • attribution for each layout shift contributing to CLS as a simplified list of shifted elements and the shift score
    • FID and INP interaction targets and types
  • Reverting the table-specific user setting
  • Adding usage instructions to the README

image

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I like it. Thanks for cleaning up.

I wish there was a way of presenting the CLS data better (e.g. in table format) but think this is the best we can do, while maintaining grouping and ability to hover the element to highlight it.

@tunetheweb
Copy link
Member

@mmocny we good to merge this, or are you in the middle of your updates so woulds rather hold off for a bit?

@gilbertococchi any comments on this?

@mmocny
Copy link
Member

mmocny commented Apr 26, 2023

Oh damn, I didn't see this and had a very similar patch locally. Let's land this one and I'll rebase.

@tunetheweb tunetheweb merged commit 3f7b025 into master Apr 26, 2023
1 check passed
@gilbertococchi
Copy link
Contributor

This is amazing, +1 to the latest changes with Grouping, I agree that putting the prefix in the table was a workaround and I like the fact that it allowed to have the "Target" as clickable element as well. LGTM

@tunetheweb tunetheweb mentioned this pull request May 2, 2023
@tunetheweb tunetheweb deleted the logs branch August 15, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants