Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete steam_workshop_enabled from options #384

Open
KANAjetzt opened this issue Apr 5, 2024 · 0 comments
Open

Delete steam_workshop_enabled from options #384

KANAjetzt opened this issue Apr 5, 2024 · 0 comments
Assignees
@KANAjetzt
Labels
4.x breaking Breaking change refactor / cleanup Improves readability or maintainability
Milestone
4.x - 7.0.0

Comments

@KANAjetzt
Copy link
Collaborator

With PR #369, we added the option to load from multiple sources and deprecated the steam_workshop_enabled option. In PR #381, we removed all deprecations, but the option wasn't deleted.
@KANAjetzt KANAjetzt added refactor / cleanup Improves readability or maintainability breaking Breaking change 4.x labels Apr 5, 2024
@KANAjetzt KANAjetzt added this to the 4.x - 7.0.0 milestone Apr 5, 2024
@KANAjetzt KANAjetzt self-assigned this Apr 5, 2024
KANAjetzt added a commit to KANAjetzt/godot-mod-loader that referenced this issue Apr 23, 2024
@KANAjetzt
refactor: 🔥 removed steam_workshop_enabled option
ecc213e 
It has been replaced by the `load_from_steam_workshop` option.

closes GodotModding#384
@KANAjetzt KANAjetzt mentioned this issue Apr 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 25, 2024
@KANAjetzt
refactor: 🔥 removed steam_workshop_enabled option (#399)
85a4de7 
It has been replaced by the `load_from_steam_workshop` option.

closes #384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KANAjetzt KANAjetzt

Labels
4.x breaking Breaking change refactor / cleanup Improves readability or maintainability
Projects
None yet
Milestone
4.x - 7.0.0
Development

No branches or pull requests
1 participant
@KANAjetzt