improve CsvTransactionsExporter #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnemonic78
reviewed
Jun 29, 2024
| @@ -53,7 +53,7 @@ | |||
| * @author Ngewi Fet <[email protected]> | |||
| * @author Yongxin Wang <[email protected]> | |||
| */ | |||
| public abstract class Exporter implements Closeable { | |||
| public abstract class Exporter { | |||
There was a problem hiding this comment.
As I mentioned in the commit description, the subclasses of Exporter already call close() in generateExport(), so there is no need for the users of the class to call close().
app/src/main/java/org/gnucash/android/export/csv/CsvTransactionsExporter.kt
Show resolved
Hide resolved
djbrown
approved these changes
Jul 6, 2024
Since the subclasses call close() on their own in generateExport(), there is no need for the users of these classes to close the exporters.
Convert the code to Kotlin, make sure the CsvWriter is closed in case of exceptions, and fix string formatting in Money. The latter change removes the `Money.toLocaleString` method which converted the amount to a double and formatted it with two decimal places (instead of the currency-appropriate formatting).
|
PTAL, since this is related to #169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to Kotlin, and fix minor issues.