Fix multi-id mode and va e2e tests when ran locally #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to prevent the e2e va test to fail when ran against local env (localhost).
VA E2E tests are currently failing because we use a cookie to store the va token on initial request but use
sameSite = none. But in localhost env the cookie will not be properly set/retrieved because of that policy.As a result, the test fails with a
Authentication missing to access this contenterror.The same issue happens when testing multi-id mode (preview) locally as we store the content token passed in the preview URL into a cookie with the same policy.