Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time-to-first-plot improvements #1278

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Time-to-first-plot improvements #1278

wants to merge 3 commits into from

Commits on Apr 22, 2019

  1. Remove unnecessary splatting from internal interfaces 

    This gives a marginal improvement on speed and memory use during first
plot, but the biggest benefit is that it makes the code easier to read
and the profiling significantly easier to grok.
    @non-Jedi
    non-Jedi committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    0f11ad0 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Compare nothing by type rather than by value 

    Comparing nothing by value (==, =!) rather than by identity (===, !==)
or by type (isnothing) can have negative consequences on code
speed. This commit changes all nothing comparisons to use the
isnothing utility added in Julia 1.1 and Compat 2.1.
    @non-Jedi
    non-Jedi committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    bf5bd2e View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. Compare nothing values with === 

    Per comment from @ararslan, the Julia compiler may prefer === versus
isnothing; improvements to be confirmed with benchmarking.
    @non-Jedi
    non-Jedi committed May 8, 2019
    Configuration menu
    Copy the full SHA
    80ae3df View commit details
    Browse the repository at this point in the history