Fix potential Gatekeeper problems by removing the `LD_RUNPATH_SEARCH_…

…PATHS` referencing outside the App bundle for macOS targets. (CocoaPods#10954)
GetToSet · May 17, 2023 · 6322f83 · 6322f83
1 parent 5773558
commit 6322f83
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,7 +12,11 @@ To install release candidates run `[sudo] gem install cocoapods --pre`
 
 ##### Bug Fixes
 
-* None. 
+* Fix potential Gatekeeper problems by removing the `LD_RUNPATH_SEARCH_PATHS` referencing outside the App bundle for
+ macOS targets. 
+ [Ethan Wong](https://github.com/GetToSet)
+ [#11837](https://github.com/CocoaPods/CocoaPods/pull/11773)
+ [#10954](https://github.com/CocoaPods/CocoaPods/issues/10954)
 
 
 ## 1.12.1 (2023-04-18)

diff --git a/lib/cocoapods/target/build_settings.rb b/lib/cocoapods/target/build_settings.rb
@@ -359,7 +359,7 @@ def _ld_runpath_search_paths(requires_host_target: false, test_bundle: false, us
  else
  "'@loader_path/Frameworks'"
  end
- paths << '${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}' if uses_swift
+ paths << '${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}' if uses_swift && test_bundle
  else
  paths << "'@executable_path/Frameworks'"
  paths << "'@loader_path/Frameworks'"

diff --git a/spec/unit/target/build_settings/aggregate_target_settings_spec.rb b/spec/unit/target/build_settings/aggregate_target_settings_spec.rb
@@ -440,7 +440,7 @@ def pod_target(spec, target_definition)
  mock_user_target = mock('usertarget')
  mock_user_target.stubs(:symbol_type).returns(:application)
  @target.stubs(:user_targets).returns([mock_user_target])
- @generator.generate.to_hash['LD_RUNPATH_SEARCH_PATHS'].should == %q[$(inherited) /usr/lib/swift '@executable_path/../Frameworks' '@loader_path/Frameworks' "${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}"]
+ @generator.generate.to_hash['LD_RUNPATH_SEARCH_PATHS'].should == "$(inherited) /usr/lib/swift '@executable_path/../Frameworks' '@loader_path/Frameworks'"
  end
 
  it 'uses the target definition swift version' do