Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render manifest.json as json file #1321

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Render manifest.json as json file #1321

merged 1 commit into from
Dec 2, 2024

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Dec 2, 2024

  • It was rendered as plain text; this had no impact on its readability, but it is still preferable to respect the convention
  • Usage of getServerSideProps instead of getInitialProps to render the file.

@dtrucs dtrucs requested a review from a team December 2, 2024 15:58
@dtrucs dtrucs merged commit 8848bb7 into develop Dec 2, 2024
2 checks passed
@dtrucs dtrucs deleted the Render-manifest-json-as-json-file branch December 2, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabhub mabhub mabhub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtrucs @mabhub