NPI-3669 Migrate SP3 transform and trim, introduce minimal SP3 creation utility script #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r codebase), add more trimming options, introduce utility script for making minimal SP3 files, primarily intended for unit tests
|
It turns out the approach taken to store the SV counts in the header, isn't currently compatible with the way we merge header attributes when combining DataFrames. |
…() including new functionality to take first n epochs
…date test_file_creation_util.py
|
After this PR is merged, we should make another dev release (probably |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds an additional SP3 trimming option, on top of what existed in the original version.
The new utility script is primarily intended for making minimal SP3 files for unit tests.
Speaking of unit tests:
filter_by_svs(): test now donetransform_sp3(): not practical to unit test. It's a wrapper for file read (including parse) / transform / write (including generate), so we should test the parse, generate and various transforming functions in isolation.