Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1544: Fix - Create Map action triggers client error #1547

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

dsuren1
Copy link

@dsuren1 dsuren1 commented Sep 5, 2023

Description

This PR fixes the Rendered fewer hooks than expected exception

Issue

@dsuren1 dsuren1 self-assigned this Sep 5, 2023
@dsuren1 dsuren1 linked an issue Sep 5, 2023 that may be closed by this pull request
Copy link
Collaborator

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an anti-pattern see https://legacy.reactjs.org/docs/hooks-rules.html#only-call-hooks-at-the-top-level

image

I think we need a wrapper component that manage the visibility

@allyoucanmap allyoucanmap merged commit 065b4cd into GeoNode:master Sep 7, 2023
1 check passed
chumano pushed a commit to cec-tris/geonode-mapstore-client that referenced this pull request Sep 13, 2023
chumano pushed a commit to cec-tris/geonode-mapstore-client that referenced this pull request Mar 29, 2024
chumano pushed a commit to cec-tris/geonode-mapstore-client that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Create Map action triggers client error
2 participants