Forward all clicks by default for UHID and AOA #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the possibility to only control the device with any keyboard and mouse mode without screen mirroring. This is different from OTG mode, which does not require USB debugging at all. Here, the standard mode is used but with the possibility to disable video playback. By default, always open a window (even without video playback), and add an option --no-window. Fixes #4727 <#4727> Fixes #4793 <#4793> PR #4868 <#4868>
In relative mouse modes (when the cursor appears on the device), it makes more sense to forward all clicks (disable HOME/BACK shortcuts on secondary clicks). Transform the boolean option --forward-all-clicks into a 3-state option: - --forward-all-clicks=true or --forward-all-clicks: enable - --forward-all-clicks=false: disable - --forward-all-clicks=auto (default): enable only for UHID and AOA That way, by default, all clicks are forwarded with `scrcpy -M`. Refs <#4727 (comment)>
2 tasks
|
Or maybe it would be more consistent to keep # SDK mouse: forward all clicks is disabled
scrcpy
# UHID mouse: forward all clicks is enabled
scrcpy -M
# SDK mouse: force enabled
scrcpy --forward-all-clicks
# UHID mouse: force disabled
scrcpy -M --no-forward-all-clicksWhat do you think? |
rom1v
force-pushed
the
window
branch
3 times, most recently
from
be9bf7d
to
e250628
Compare
rom1v
force-pushed
the
window
branch
3 times, most recently
from
14348f4
to
063a833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relative mouse modes (when the cursor appears on the device), it makes more sense to forward all clicks (disable HOME/BACK shortcuts on secondary clicks).
Transform the boolean option
--forward-all-clicksinto a 3-state option:--forward-all-clicks=trueor--forward-all-clicks: enable--forward-all-clicks=false: disable--forward-all-clicks=auto(default): enable only for UHID and AOAThat way, by default, all clicks are forwarded with
scrcpy -M.Refs #4727 (comment)