Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Wpedantic warnings #4220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yangfl
Copy link
Contributor

@yangfl yangfl commented Aug 6, 2023

No description provided.

@rom1v
Copy link
Collaborator

rom1v commented Aug 7, 2023

In scrcpy, I decided to accept compound statements. Removing some of them will not solve all warnings, I use this feature everywhere in vector and vecdeque. Tested with:

diff --git a/meson.build b/meson.build
index 847e33a10..2ed00fb51 100644
--- a/meson.build
+++ b/meson.build
@@ -3,7 +3,7 @@ project('scrcpy', 'c',
         meson_version: '>= 0.48',
         default_options: [
             'c_std=c11',
-            'warning_level=2',
+            'warning_level=3',
             'b_ndebug=if-release',
         ])
 

(there are a lot of warnings).

See my comments here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants