Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status update #5

Merged
merged 9 commits into from
Jul 21, 2023
Merged

Status update #5

merged 9 commits into from
Jul 21, 2023

Conversation

GeekyHacks
Copy link
Owner

@GeekyHacks GeekyHacks commented Jul 20, 2023

In this PR I did the following:

  • Added the updateStatus class which updates the status of completed property inside the task object and gives you access to delete completed tasks
  • Fixed linter errors

@GeekyHacks GeekyHacks temporarily deployed to github-pages July 20, 2023 08:11 — with GitHub Pages Inactive
@GeekyHacks GeekyHacks temporarily deployed to github-pages July 20, 2023 23:09 — with GitHub Pages Inactive
@GeekyHacks GeekyHacks temporarily deployed to github-pages July 21, 2023 07:02 — with GitHub Pages Inactive
@GeekyHacks GeekyHacks temporarily deployed to github-pages July 21, 2023 07:44 — with GitHub Pages Inactive
@GeekyHacks GeekyHacks temporarily deployed to github-pages July 21, 2023 08:01 — with GitHub Pages Inactive
@GeekyHacks GeekyHacks temporarily deployed to github-pages July 21, 2023 08:03 — with GitHub Pages Inactive
Copy link

@elisha2kyakpo1 elisha2kyakpo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 @GeekyHacks,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

✔️ The PR title and description are good and professional.
✔️ No linter errors.
✔️ Descriptive readme file.
✔️ Clears all completed tasks👏
👏 The app works as expected.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@GeekyHacks GeekyHacks temporarily deployed to github-pages July 21, 2023 15:33 — with GitHub Pages Inactive
@GeekyHacks GeekyHacks merged commit 1d66f3f into main Jul 21, 2023
@GeekyHacks GeekyHacks temporarily deployed to github-pages July 21, 2023 15:36 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants