fix: use "base" fontFamily in web #5648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GuilleDF is attempting to deploy a commit to the Geekyants Team Team on Vercel. A member of the Team first needs to authorize it. |
|
Update: I added an example for testing, but feel free to discard it if it's not useful :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fontFamily prop generated currently looks like
FontName-MediumItalic. This is generally how it's expected by react-native, but not how a browser would expect it. On web, the font family is generally onlyFontNameand other props such asfontWeightare used in conjunction. This disables the logic to generate this "compound" fontFamily for web.Changelog
[Web] [Changed] - Use normal fontFamily in web
Test Plan
I ran the testbed and checked the Text stories to see if something broke.