Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts): ref? expanded to ForwardedRef | Ref #5432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ts): ref? expanded to ForwardedRef | Ref #5432

wants to merge 1 commit into from

Conversation

stackchain
Copy link

@stackchain stackchain commented Sep 28, 2022 •
edited
Loading

Summary

Issue identified #5158.

Bumped @react/types package.

Created the utility type GenericRef<T> that covers React.createRef, React.useRef and React.forwardRef refs.

Changelog

[Typescript] [Fix] - fixes ref definition, by expanding it to the GenericRef utility type.

Test Plan

It is not a breaking change.

@vercel
Copy link

vercel bot commented Sep 28, 2022

@stackchain is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@stackchain stackchain marked this pull request as ready for review September 29, 2022 00:07
@auto-assign auto-assign bot requested a review from rayan1810 September 29, 2022 00:07
@stackchain stackchain changed the title fix(ts): ref? expanded to ForwardedRef fix(ts): ref? expanded to ForwardedRef | Ref Sep 29, 2022
@atanaskanchev
Copy link

@rayan1810 Shall we get this one merge, the issue still persist in 3.4.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayan1810 rayan1810 Awaiting requested review from rayan1810

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stackchain @atanaskanchev