Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: space-evenly not working in Stack component #5125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nbsp1221
Copy link

@nbsp1221 nbsp1221 commented Jul 5, 2022

Summary

Hi! I found an issue that justifyContent="space-evenly" not working in Stack component and fixed it.

AS-IS

image

TO-BE

image

Here is the code I used for testing.

export function Example() {
  return (
    <Stack
      direction="row"
      bg="gray.200"
      width={500}
      justifyContent="space-evenly"
    >
      <Center
        size="16"
        bg="primary.400"
        _text={{ color: 'warmGray.50', fontWeight: 'medium' }}
      >
        Box 1
      </Center>
      <Center
        size="16"
        bg="primary.500"
        _text={{ color: 'warmGray.50', fontWeight: 'medium' }}
      >
        Box 2
      </Center>
      <Center
        size="16"
        bg="primary.600"
        _text={{ color: 'warmGray.50', fontWeight: 'medium' }}
      >
        Box 3
      </Center>
      <Center
        size="16"
        bg="primary.700"
        _text={{ color: 'warmGray.50', fontWeight: 'medium' }}
      >
        Box 4
      </Center>
      <Center
        size="16"
        bg="primary.800"
        _text={{ color: 'warmGray.50', fontWeight: 'medium' }}
      >
        Box 5
      </Center>
    </Stack>
  );
}

Changelog

[General] [Fixed] - Fix issue that space-evenly not working in Stack component

Test Plan

@auto-assign auto-assign bot requested a review from surajahmed July 5, 2022 10:08
@vercel
Copy link

vercel bot commented Jul 5, 2022

@nbsp1221 is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@nbsp1221 nbsp1221 changed the title fix: space-evenly not working in Stack component fix: space-evenly not working in Stack component Jul 5, 2022
@nbsp1221
Copy link
Author

@surajahmed any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant