fix: Select container pressable functionality fixed.

[oguzhnatly]

Summary

The action sheet does not open when the current select container is pressed. The only button that could be pressed was the dropdown icon. I fixed it by adding the onPressIn prop to its input to be able to open the action sheet.

Changelog

[General] [Fixed] - Pressable function added to Select's input as onPressIn.

Test Plan

It does not change the user interface.

[vercel]

@oguzhnatly is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

[surajahmed]

@oguzhnatly Thanks for working on this. We've already fixed this here ea38f62

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dimaslz]

@oguzhnatly Thanks for working on this. We've already fixed this here ea38f62

Hello @oguzhnatly, when is planned to release the next version to include that fix?, I am blocked now because on Android, the Select component works as InputText.

Thanks!

[jgudo]

Hello @oguzhnatly, when is planned to release the next version to include that fix?, I am blocked now because on Android, the Select component works as InputText.

Same issue. The Select component acts like Input which toggles the keyboard

[oguzhnatly]

Hello @oguzhnatly, when is planned to release the next version to include that fix?, I am blocked now because on Android, the Select component works as InputText.

Same issue. The Select component acts like Input which toggles the keyboard

@oguzhnatly Thanks for working on this. We've already fixed this here ea38f62

Hello @oguzhnatly, when is planned to release the next version to include that fix?, I am blocked now because on Android, the Select component works as InputText.

Thanks!

Hi @jgudo ad @dimaslz, thank you for supporting my PR. However, I'm neither a reviewer, authorized to approve nor make approval for this in this NativeBase. Please contact with or tag @surajahmed!

[LuizCristino]

This commit ea38f62 didn't resolve the problem, at least for me, it didn't.

Had to change this line to make it work properly on Android.

      <Pressable
        onPress={() => {
          Keyboard.dismiss();
          setIsOpen(true);
          onOpen && onOpen();
        }}
        disabled={isDisabled}
        accessibilityLabel={accessibilityLabel}
        accessibilityRole="button"
        ref={mergeRefs([ref, _ref])}
+       pointerEvents='box-only'
        {...layoutProps}
      >

[enchorb]

This is still an issue on Android...pressing the Select input will open the keyboard and hide the bottom sheet.

[LuizCristino]

This is still an issue on Android...pressing the Select input will open the keyboard and hide the bottom sheet.

Try this fix with patch-package

diff --git a/node_modules/native-base/src/components/primitives/Select/Select.tsx b/node_modules/native-base/src/components/primitives/Select/Select.tsx
index ee8df1e..0647471 100644
--- a/node_modules/native-base/src/components/primitives/Select/Select.tsx
+++ b/node_modules/native-base/src/components/primitives/Select/Select.tsx
@@ -188,6 +188,7 @@ const Select = (
         accessibilityRole="button"
         ref={mergeRefs([ref, _ref])}
         {...layoutProps}
+        pointerEvents='box-only'
       >
         {commonInput}
       </Pressable>