Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new fab props #4921

Open
wants to merge 1 commit into
base: minor
Choose a base branch
from

Conversation

shivamkawde18
Copy link

The fab component only accepts the following values for its placement prop:
"top-right" | "top-left" | "bottom-right" | "bottom-left".
Added new props for fab component-
->”top-center”
->”bottom-center”
->”center”
->”left-center”
->”right-center”

@auto-assign auto-assign bot requested a review from surajahmed April 12, 2022 12:57
@vercel
Copy link

vercel bot commented Apr 12, 2022

Someone is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 12, 2022
@jd1378
Copy link

jd1378 commented Jul 7, 2022

any news on this ?

@stale stale bot removed the stale label Jul 7, 2022
@jpike88
Copy link

jpike88 commented Jul 12, 2022

I've noticed an issue: left '50%' does not perfectly centre the FAB.
Screen Shot 2022-07-12 at 09 46 59
.

@jd1378
Copy link

jd1378 commented Jul 12, 2022

I've noticed an issue: left '50%' does not perfectly centre the FAB. Screen Shot 2022-07-12 at 09 46 59 .

It certainly will not, from my experience on web, in addition to 50 % left, you need to transformX it to the left by 50 percent so it perfectly center it

@jpike88
Copy link

jpike88 commented Jul 12, 2022

on web yes, on other platforms the transform property doesn't exist

@jd1378
Copy link

jd1378 commented Jul 12, 2022

im not sure, but is it possible to wrap it in another component and margin from both sides ?

edit: or can use a flex wrapper and centerize the element

edit2: tried , couldnt make it work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants