feat: Exposing underlying Image properties on Avatar via _image #4592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have several use cases where I need to modify properties on the Avatars underlying image. This change adds _image to the avatar in a similar fashion to other cases e.g. _text
Changelog
[General] [Added] - Added
_image
property to Avatar to expose the underlying image propertiesTest Plan
I've been using the patch successfully to drive underlying image tinting based on a focus property. I'm happy to add automated tests if someone can point me in the right direction.
One area I'd question, and ask reviewsers to chime in on, is should the _image props allow override of all props provided by the avatar or are there some that should never be overiden? I.e. is
{..._image}
placed correctly in the props order on the Image tag.