Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Breadcrumb and Checkbox require cycles warnings #4292

Open
wants to merge 2 commits into
base: minor
Choose a base branch
from

Conversation

fervailanti
Copy link

Summary

Some circular requiring were causing this warning to appear:

Captura de pantalla 2021-11-10 a las 21 36 33

Changelog

  • [General] [Fixed] - Fixed Pressable requiring in Breadcrumb component
  • [General] [Fixed] - Fixed Box requiring in Checkbox (SizedIcon) component

Test Plan

The warning disappears.

@vercel
Copy link

vercel bot commented Nov 10, 2021

@fervailanti is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@JMRBDev
Copy link

JMRBDev commented Nov 26, 2021

Will this eventually be merged?

@surajahmed surajahmed deleted the branch GeekyAnts:minor December 23, 2021 12:44
@surajahmed surajahmed closed this Dec 23, 2021
@surajahmed surajahmed reopened this Jan 14, 2022
@3kwtloo
Copy link

3kwtloo commented Jan 29, 2022

Thx for the PR - I suggest applying these changes as well to src/components/composites/Transitions/Slide.tsx:

diff --git a/node_modules/native-base/src/components/composites/Transitions/Slide.tsx b/node_modules/native-base/src/components/composites/Transitions/Slide.tsx index 7e63779..3e589fa 100644 --- a/node_modules/native-base/src/components/composites/Transitions/Slide.tsx +++ b/node_modules/native-base/src/components/composites/Transitions/Slide.tsx @@ -4,7 +4,7 @@ import { useThemeProps } from '../../../hooks/useThemeProps'; import type { ISlideProps } from './types'; import PresenceTransition from './PresenceTransition'; import { useHasResponsiveProps } from '../../../hooks/useHasResponsiveProps'; -import { Overlay } from '../../primitives'; +import { Overlay } from '../../primitives/Overlay/Overlay';

I was getting another dip cycle with the latest version from npm as well

@md-rehman md-rehman changed the base branch from master to minor February 4, 2022 10:00
@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants