Improved piano player and auto play #1214
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ new menu + autoplay + progress slider + select chanel
Adrieennn
approved these changes
Jul 17, 2020
christophezei
approved these changes
Jul 17, 2020
There was a problem hiding this comment.
The changes works fine.
I only have some comments that can improve the game:
- I realized while in manual mode you can hear the song before clicking on the intended key.
- When the game ends we don't have any feedback and we can't play anymore unless we drag the progress bar to the beginning this could be more user friendly by ending the game once the song finishes like other games .
|
@kuhlkrein before merging, add @christophezei's comments as issues |
@schwabdidier done |
|
I fixed the second point given by christophe |
|
fix #1158 |
kuhlkrein
commented
Jul 28, 2020
|
|
||
|
|
||
| public void start() { | ||
| if (!sequencer.isRunning()) { |
There was a problem hiding this comment.
We have to change this function to avoid play before touching key
|
Do not merge for now |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements for being able to play most of the midi files with PianoSight