Enable error_reporting in php.ini and add problem matcher

GW2Treasures · Feb 7, 2024 · 854a120 · 854a120
1 parent 4794910
commit 854a120
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -41,10 +41,14 @@ jobs:
       with:
         php-version: ${{ matrix.php }}
         ini-values: |
-          phar.readonly=false
+          phar.readonly = false
+          error_reporting = E_ALL
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+    - name: Setup problem matchers for PHPUnit
+      run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"
+
     - name: Validate composer.json and composer.lock
       run: composer validate --strict
 

diff --git a/tests/BasicTestCase.php b/tests/BasicTestCase.php
@@ -17,8 +17,6 @@
 use Psr\Http\Message\RequestInterface;
 use PHPUnit\Framework\TestCase;
 
-error_reporting(E_ALL);
-
 abstract class BasicTestCase extends TestCase {
     /** @var GW2Api $api */
     protected $api;