Don't show Ringing window fullscreen and center it rather #1876
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is so much wrong with that window, in every conceivable way. As I mentioned in #1875 (comment) it might even be worth considering that we just dump the window entirely in favor of a notification. Now that action buttons on notifications persist into the drawer and can still be clicked even if you miss the popup, that's not so unworkable as it used to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made this change because when that dialog is maximized it was broken and only covered top right quadrant for some reason looking very out of place.
Also removed the dismissal of dialog on hover over it because it seemed abrupt and made it so the main button the dialog can't be clicked at all, making it a very confusing UX that seemed broken and as if its crashing abruptly.