Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel 7 upgrade #1371

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Babel 7 upgrade #1371

wants to merge 12 commits into from

Conversation

cmdcolin
Copy link
Contributor

This puts the JBrowse codebase on solid babel-7 footing, and does less weird stuff with specific exclusions for excluding node_modules in the babel-loader.

@cmdcolin
Copy link
Contributor Author

Looks like tests get stuck unfortunately

@cmdcolin
Copy link
Contributor Author

It looks like babel 7 changes to behavior of some usages of this.inherited. I don't know exactly how it is but you can see from the commit log on this branch some instances that needed changes to make it work (otherwise infinite recursions would occur and stuff)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant