Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of url node module #134

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Remove usage of url node module #134

merged 1 commit into from
Mar 18, 2024

Conversation

cmdcolin
Copy link
Contributor

the end result being that less polyfills are needed. the behavior of 'dynamically switching to use localfile' is something that can instead be solved by user code if they need it

@cmdcolin
Copy link
Contributor Author

xref GMOD/jbrowse-components#4296

@cmdcolin cmdcolin force-pushed the remove_url branch 3 times, most recently from 3524f3c to 8cca646 Compare March 18, 2024 14:36
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.26%. Comparing base (9021a23) to head (c7dae63).

❗ Current head c7dae63 differs from pull request most recent head 814e925. Consider uploading reports for the commit 814e925 to get more accurate results

Files Patch % Lines
src/io/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   90.21%   90.26%   +0.05%     
==========================================
  Files          39       38       -1     
  Lines        1962     1952      -10     
  Branches      395      400       +5     
==========================================
- Hits         1770     1762       -8     
+ Misses        191      176      -15     
- Partials        1       14      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmdcolin cmdcolin merged commit 8db17b9 into master Mar 18, 2024
1 check passed
@cmdcolin cmdcolin deleted the remove_url branch April 16, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant