Benchmark compilation issues on lassen / pecan with cpp17 + cuda11 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbett5
reviewed
Jul 1, 2023
There was a problem hiding this comment.
So you hand inlined makeRajaView and that fixed the problem? Not a huge fan of the solution, but it seems like a nasty problem...
Just curious if you tried changing the return type of makeRajaView to auto and or changed the variable assigned to from makeRajaView to auto. You never know what might trip up NVCC and get it to actually work haha.
|
@wrtobin, I just saw your commit message, I love it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.