CI/CD script for v2.6.1-gr #3
Merged
+309
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-krystianc
commented
Jan 2, 2025
There was a problem hiding this comment.
I tested that script in my personal org, here are the packages published with it -> https://github.com/marcin-krystianc?tab=packages
| @@ -26,7 +26,7 @@ else | |||
| fi | |||
|
|
|||
|
|
|||
| ./packaging/mingw-w64/run-tests.sh | |||
| # ./packaging/mingw-w64/run-tests.sh | |||
There was a problem hiding this comment.
Tests take a long time to run (especially in the QEMU environment) and are flaky.
| @@ -122,7 +122,7 @@ fi | |||
|
|
|||
| # Run quick test suite, mark it as CI to avoid time/resource sensitive | |||
| # tests to fail in case the worker is under-powered. | |||
| CI=true make -C tests run_local_quick | |||
| # CI=true make -C tests run_local_quick | |||
There was a problem hiding this comment.
Tests take a long time to run (especially in the QEMU environment) and are flaky.
adamreeve
reviewed
Jan 3, 2025
Thanks for the review, these were all remnants from the original |
adamreeve
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.