-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New System for Tile Map, Tile Set, and Brush #714
base: master
Are you sure you want to change the base?
Conversation
…pendent of mouse position.
…dated versions later.
17k lines... O. M. G. That's for sure will take some time to review :) |
I think it might be wise to rename material pages to atlas pages and change the names of related concepts to match. I may not have given enough thought to what things are named in this project, so there may be other names that should be changed. |
If anything is in any way confusing or unclear, I would be very happy to add comments, rename things, re-organize things, or in other ways adjust the PR so that it is easier to understand. |
I'm on the review, the PR is just... too large. I mean it is probably one of the largest PR I've ever seen including ones at work. I'm half way through it. |
It would be great to have advice on method names, parameter order, and generally making sure that everything fits in with a consistent Fyrox style. |
This tile map system is still a work in progress, but it is now a work in progress that is actually useable. It does everything the current tile map system can do and more. After weeks of working on it alone, I am making this pull request so that I can get some help with this enormous project. I cannot find all the problems with it myself, though I have tried and it seems to work quite well. There is just too much for one person.
It needs a lot more documentation and testing, but here are the major features that it already has:
TileMap
to remove the list of brushes that is no longer needed. If there is a need to switch brushes, the current brush can be changed by dragging a brush asset into the tile map control panel.