-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements fully working hierarchical lexical scopes. #6784
Open
esdrubal
wants to merge
19
commits into
master
Choose a base branch
from
esdrubal/hierarchical_lexical_scopes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added
code quality
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
labels
Dec 11, 2024
…on_ctx.namespace lexical scopes.
This optimization is now removed from the TraitMAp because it breaks the insert_implementation_for_type of mutable references.
esdrubal
force-pushed
the
esdrubal/hierarchical_lexical_scopes
branch
from
December 12, 2024 15:09
920ca89
to
aaed7cc
Compare
CodSpeed Performance ReportMerging #6784 will degrade performances by 59.03%Comparing Summary
Benchmarks breakdown
|
esdrubal
force-pushed
the
esdrubal/hierarchical_lexical_scopes
branch
from
December 12, 2024 15:44
a97bf73
to
c5f0f07
Compare
esdrubal
force-pushed
the
esdrubal/hierarchical_lexical_scopes
branch
from
December 12, 2024 15:47
c5f0f07
to
62fd6dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code quality
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the missing elements for the hierarchical lexical scopes.
TypeCheckContext no longer uses cloned namespaces. Instead, we push and pop lexical scopes.
For this to work multiple places that used current_items now either use root_items or traverse the lexical scopes.
Checklist
Breaking*
orNew Feature
labels where relevant.