Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error when contract method names conflict #6782

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Dec 10, 2024

Description

Today, contract call uses the method name to identify which contract method to call. That means that a contract cannot have multiple methods with the same name.

That can happen when a contract implements traits:

error
   --> /home/xunilrj/github/example/main.sw:185:8
    |
183 |  
184 |     
185 |     fn f() -> Option<u64> {
    |        ^^^^^^^^^^^^ Multiple contracts methods with the same name.
186 |         
187 |             
    |
____

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #6782 will not alter performance

Comparing xunilrj/error-contract-method-conflict (ce06771) with master (192f163)

Summary

✅ 22 untouched benchmarks

@xunilrj xunilrj marked this pull request as ready for review December 16, 2024 15:57
@xunilrj xunilrj requested a review from a team as a code owner December 16, 2024 15:57
@xunilrj xunilrj self-assigned this Dec 16, 2024
@xunilrj xunilrj changed the title Error contract method conflict Show error when contract method names conflict Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants