A few updates to improve code clarity #6777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @sharma-shray to sign the Fuel Labs Contributor License Agreement. |
IGI-111
reviewed
Dec 9, 2024
| @@ -4178,7 +4178,7 @@ impl<'eng> FnCompiler<'eng> { | |||
| .get_elem_ptr_with_idx(tuple_value, field_type, idx as u64) | |||
| .add_metadatum(context, span_md_idx) | |||
| }) | |||
| .ok_or_else(|| { | |||
| .ok_or({ | |||
There was a problem hiding this comment.
These do not have the same behavior.
There is no need to eagerly evaluate an error, surely?
Comment on lines
-1837
to
-1838
| // FIXME we can do better here and return function application expression here | ||
| // if there are no parsing errors in the arguments |
There was a problem hiding this comment.
What's the rationale for removing this altogether?
Comment on lines
+2492
to
+2501
| let call_path = CallPath { | ||
| prefixes: vec![ | ||
| Ident::new_with_override("core".into(), op_span.clone()), | ||
| Ident::new_with_override("ops".into(), op_span.clone()), | ||
| ], | ||
| suffix: Ident::new_with_override(name.into(), op_span.clone()), | ||
| is_absolute: true, | ||
| }; | ||
| let method_name_binding = TypeBinding { | ||
| inner: MethodName::FromTrait { | ||
| call_path: CallPath { | ||
| prefixes: vec![ | ||
| Ident::new_with_override("core".into(), op_span.clone()), | ||
| Ident::new_with_override("ops".into(), op_span.clone()), | ||
| ], | ||
| suffix: Ident::new_with_override(name.into(), op_span.clone()), | ||
| is_absolute: true, | ||
| }, | ||
| }, | ||
| inner: MethodName::FromTrait { call_path }, |
There was a problem hiding this comment.
I don't see how breaking it out makes it clearer here. You've undone it in other instances in this very PR.
CodSpeed Performance ReportMerging #6777 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
type anotation, extracting the creation of the CallPath into a separate variable for easier understanding, Inline Destructuring for Simpler Match Pattern
Checklist
Breaking*orNew Featurelabels where relevant.