-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dynamic types in configurables #6760
Open
xunilrj
wants to merge
13
commits into
master
Choose a base branch
from
xunilrj/dynamic-types-configurables
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunilrj
force-pushed
the
xunilrj/dynamic-types-configurables
branch
from
November 26, 2024 22:15
0383319
to
e4a24e9
Compare
CodSpeed Performance ReportMerging #6760 will not alter performanceComparing Summary
|
xunilrj
force-pushed
the
xunilrj/dynamic-types-configurables
branch
2 times, most recently
from
December 2, 2024 11:38
869de4b
to
6f3f3be
Compare
xunilrj
force-pushed
the
xunilrj/dynamic-types-configurables
branch
from
December 10, 2024 18:05
f6ae306
to
4a625ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements "dynamic types" for configurables. This means those types which the encoded bytes buffer does not have a know size at compilation time. For example: Vec, Dictionaries, string slices etc...
The major problem these pose is that the ABI json has the offset to their encoded bytes; and if their buffer size changes, that would invalidate the offset of configurables coming after them inside the json.
To solve this issue, these types will have their buffer read indirectly. This means that, at the predefined offset will be another offset, this last one from the start of the data section that will point to their encoded bytes, which can be shared if needed as it is read-only.
If the buffer is not reused, it is expected that it will live at the end of the binary, where it will not invalidate any of the ABI json offsets.
Example:
Each
config
at the IR has a new field for some "flags". Currently we only have one flag, which is if the decode is direct (0) or indirect(1). Direct means that the encoded bytes are inside the configurable section. Indirect means that the compiler puts an offset inside the configurable section, but the encoded bytes will be append at the end of the binary.The generated asm now have a new ".offset of", which will be materialized into the offset from the start of
.data
section (NOT the configurable section).and the generated bytecode will be:
The
.data
section offset can be read directly from the binary as it lives at the start of the binary.more precisely at:
Checklist
Breaking*
orNew Feature
labels where relevant.