Fix clobbering of process vs component vs forc #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfiedotwtf
force-pushed
the
alfie/resolve-proxy
branch
from
e16411b to
e5318c2
Compare
JoshuaBatty
reviewed
Oct 10, 2024
JoshuaBatty
reviewed
Oct 10, 2024
alfiedotwtf
changed the title
- Checking whether or not the executable was published by forc - Checking whether or not the executable was in the store - Used to generate the tarball target - Used to generate the tarball URL - Used to generate the final target executable to run from the store Each of the above was breaking in subtle ways depending on which executable was being run. After separating out these functions based on the properly resolved component from the executable, and along with the previous commits, these problems above were resolved.
alfiedotwtf
force-pushed
the
alfie/resolve-proxy
branch
from
e5318c2 to
7329e4e
Compare
|
Can we add some tests to show how this change works? |
Yep, no problem. |
|
Keeping this PR in DRAFT but backgrounding for now... 90% of the tests have been done, I just have to do the other 90%. Backgrounding for now, but will leave this as a downtime task to complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These issues were found while investigating #654.
Currently,
component_namewas being repurposed for multiple functions:forcEach of the above was breaking in subtle ways depending on which executable was being run.
After separating out these functions based on the properly resolved component from the executable, and along with the previous commits, these problems above were resolved.